i18n: Improve zh-CN localization & fix Simplified Chinese label glyph#726
i18n: Improve zh-CN localization & fix Simplified Chinese label glyph#726Xiaocaihassome wants to merge 2 commits into
Conversation
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates zh-CN label text in two components and expands editor, shortcuts, and settings locale strings in English and zh-CN. ChangesLocale label and translation expansion
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/i18n/locales/zh-CN/settings.json (1)
286-295: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove the unused
settingsSectionsblock. The settings UI only readssections.*, so this locale-only copy will just drift over time.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/i18n/locales/zh-CN/settings.json` around lines 286 - 295, Remove the unused settingsSections locale block from the zh-CN settings JSON, since the settings UI reads sections.* instead. Update the locale entry in settings.json by deleting the settingsSections object and keep the remaining translation keys aligned with the structure used by the settings UI.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/video-editor/SettingsPanel.tsx`:
- Line 2517: The frame label JSX in SettingsPanel is missing the closing brace
for the tSettings call, making the span invalid. Update the label expression in
the frame section so the translation function call is properly closed before the
closing span tag, and verify the surrounding JSX in SettingsPanel renders
cleanly.
---
Nitpick comments:
In `@src/i18n/locales/zh-CN/settings.json`:
- Around line 286-295: Remove the unused settingsSections locale block from the
zh-CN settings JSON, since the settings UI reads sections.* instead. Update the
locale entry in settings.json by deleting the settingsSections object and keep
the remaining translation keys aligned with the structure used by the settings
UI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4c4f6849-7f9f-406a-a19d-204e81967430
📒 Files selected for processing (7)
src/components/launch/popovers/MorePopover.tsxsrc/components/video-editor/SettingsPanel.tsxsrc/i18n/locales/en/editor.jsonsrc/i18n/locales/en/shortcuts.jsonsrc/i18n/locales/zh-CN/editor.jsonsrc/i18n/locales/zh-CN/settings.jsonsrc/i18n/locales/zh-CN/shortcuts.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|
|
1 similar comment
|
|
This comment was marked as duplicate.
This comment was marked as duplicate.
|
While using Recordly on Windows, I found multiple flawed points in Simplified Chinese localization.










The language dropdown uses wrong Traditional glyph "簡體中文" instead of standard Simplified writing, fixed in MorePopover.tsx and SettingsPanel.tsx.
Many UI areas lack complete zh-CN localized text and fall back to raw English, including click effect configs, zoom blur parameters, caption editor buttons, preset & theme panels, project brow
ser, unsaved changes pop-up and timeline toolbar.
I refined zh-CN locale entries inside settings.json, editor.json and shortcuts.json, and added matching base English keys to support further language expansion.
Full local test finished on Windows 11. UI screenshots and code diffs are attached below.
Summary by CodeRabbit